Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates based on v0.6.0rc1 usability testing feedback #541

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Updates based on v0.6.0rc1 usability testing feedback #541

merged 4 commits into from
Sep 14, 2023

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Sep 13, 2023 •
edited
Loading

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder self-assigned this Sep 13, 2023
tomvothecoder
tomvothecoder commented Sep 13, 2023
View reviewed changes
xcdat/bounds.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fefbc04) 100.00% compared to head (29b8da2) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #541   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1592      1592           
=========================================
  Hits          1592      1592
Files Changed Coverage Δ
xcdat/bounds.py 100.00% <ø> (ø)
xcdat/dataset.py 100.00% <ø> (ø)
xcdat/temporal.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomvothecoder tomvothecoder added type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors. type: docs Updates to documentation labels Sep 13, 2023
@tomvothecoder
Copy link
Collaborator Author

Hey @pochedls, I'm just tagging you for a quick review since this PR includes some of your feedback.

Please refer to #540 for a list of changes.

tomvothecoder
tomvothecoder commented Sep 13, 2023
View reviewed changes
xcdat/bounds.py Outdated Show resolved Hide resolved
@tomvothecoder
Update docstrings related to time bounds
5a694f7 
- Update `_infer_freq()` upper bound limit for classifying "day" and "month" frequencies to avoid misclassifications of coordinates, especially with 360_day calendar
- Update `add_missing_bounds()` tests
@tomvothecoder
Update xcdat/bounds.py
18c503e
@tomvothecoder
Update xcdat/bounds.py
705c31a
@tomvothecoder
Fix doc code block
29b8da2
@tomvothecoder tomvothecoder merged commit 6b45211 into main Sep 14, 2023
9 checks passed
@tomvothecoder tomvothecoder deleted the usability-testing branch September 14, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pochedls pochedls Awaiting requested review from pochedls

Assignees

@tomvothecoder tomvothecoder

Labels
type: bug Inconsistencies or issues which will cause an issue or problem for users or implementors. type: docs Updates to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: General update based on v0.6.0rc1 usability testing feedback
1 participant
@tomvothecoder